[DPA-1067]: feat: support enable disable feeds managers/JD #15010
Conversation
graham-chainlink
changed the title
graham-chainlink
requested review from
eutopian,
yevshev and
a team
as code owners
graham-chainlink
changed the title
|
| @@ -1086,7 +1086,9 @@ func (s *service) Start(ctx context.Context) error { | |||
| } | |||
| } | |||
| } else { | |||
| s.connectFeedManager(ctx, mgrs[0], privkey) | |||
| if mgrs[0].DisabledAt == nil { | |||
There was a problem hiding this comment.
Are we asserting logic based on a side effect? DisabledAt reads like it would hold a timestamp as a result of a Disable action. Is there a more direct state variable you can read from? Just from reading, something like Disabled or Enabled would be more appropriate.
There was a problem hiding this comment.
Hey patrick, my auto merged kicked in and merged this PR.
But let me explain, so as you have guessed correctly ,the DisabledAt is a timestamp field in feeds manager table that holds a time when user disables a feeds manager, and enabling it will clear this field. This is the only field we have, we did started with a single Enabled field, but we ended up with DisabledAt to be consistent with other services (CLO) that we have mainly for consistency.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1067