Cappl 3 ph #15125

patrickhuie19 · 2024-11-05T17:04:39Z

Requires

Supports

Comment to build plugins Updated Use goreleaser for compute WASM artifacts

* Prep @chainlink/contracts v1.3.0 release * Update contracts release date for v1.3.0

* Revert "fix: pinning goreleaser version to fix builds (#15108)" This reverts commit 8bbff53. * fix: arm64 dist directory

* adds OZ AccessControl support to the registry module * [Bot] Update changeset file with jira issues * fix snap * update version --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>

github-actions · 2024-11-05T17:06:19Z

Static analysis results are available

Hey @cedric-cordenier, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

github-actions · 2024-11-06T11:49:26Z

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Find New Flaky Tests In Root Project / Find Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Find New Flaky Tests In Deployment Project , Core Tests (go_core_fuzz) , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/workflows/store) , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/standardcapabilities) , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/workflows) , Flakey Test Detection , SonarQube Scan , Find New Flaky Tests In Root Project / Report

1. Race condition detected in tests:[go_core_race_tests]

Source of Error:

Run tests	2024-11-07T17:03:03.4906307Z + echo 'Race(s) detected'
Run tests	2024-11-07T17:03:03.4906884Z Race(s) detected
Run tests	2024-11-07T17:03:03.4907538Z + exit 1
Run tests	2024-11-07T17:03:03.4925478Z ##[error]Process completed with exit code 1.

**Why**: The test suite detected a race condition, which indicates that multiple threads or processes are accessing shared data concurrently without proper synchronization.

Suggested fix: Use synchronization mechanisms like mutexes or channels to ensure that shared data is accessed in a thread-safe manner.

2. Foreign key constraint violation:[github.com/smartcontractkit/chainlink/v2/core/services/workflows/store]

Source of Error:

Run tests with flakeguard	2024-11-07T16:58:33.3596355Z 	 	could not insert workflow execution 6ac237bf6b80d4236ea8829fc919694b4a7dea0a359c3a8c1102fd2441c4932b: ERROR: insert or update on table "workflow_executions" violates foreign key constraint "workflow_executions_workflow_id_fkey" (SQLSTATE 23503)
Run tests with flakeguard	2024-11-07T16:58:33.3598820Z 	Test: 	Test_StoreDB_GetUnfinishedSteps
Run tests with flakeguard	2024-11-07T16:58:33.3599828Z --- FAIL: Test_StoreDB_GetUnfinishedSteps (0.01s)
Run tests with flakeguard	2024-11-07T16:58:33.3600342Z 
Run tests with flakeguard	2024-11-07T16:58:33.3600672Z Summary: 6 passed, 0 skipped, 1 failed
Run tests with flakeguard	2024-11-07T16:58:33.3601532Z All test results saved to test-result.json
Run tests with flakeguard	2024-11-07T16:58:33.3620198Z ##[error]Process completed with exit code 1.

**Why**: The test failed because it attempted to insert a record into the `workflow_executions` table that references a non-existent `workflow_id`, violating the foreign key constraint.

Suggested fix: Ensure that the referenced workflow_id exists in the workflows table before attempting to insert the record.

3. Linting errors:[golangci-lint]

Source of Error:

Golang Lint	2024-11-07T17:00:34.8112214Z core/services/standardcapabilities/standard_capabilities_test.go:7: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
Golang Lint	2024-11-07T17:00:34.8179154Z ##[error]core/services/workflows/syncer/workflow_registry.go:36:2: field `wg` is unused (unused)
Golang Lint	2024-11-07T17:00:34.8180360Z 	wg sync.WaitGroup
Golang Lint	2024-11-07T17:00:34.8180848Z 	^
Golang Lint	2024-11-07T17:00:34.8182633Z ##[error]core/services/standardcapabilities/standard_capabilities_test.go:48:1: unnecessary trailing newline (whitespace)
Golang Lint	2024-11-07T17:00:34.8183720Z 
Golang Lint	2024-11-07T17:00:34.8183878Z ^
Golang Lint	2024-11-07T17:00:34.8186907Z ##[error]core/services/workflows/syncer/workflow_registry.go:95:18: printf: (github.com/smartcontractkit/chainlink/v2/core/logger.Logger).Errorf call has arguments but no formatting directives (govet)
Golang Lint	2024-11-07T17:00:34.8188939Z 		w.Logger.Errorf("failed to get workflow spec", err)
Golang Lint	2024-11-07T17:00:34.8189728Z 		 ^
Golang Lint	2024-11-07T17:00:34.8192834Z ##[error]core/services/workflows/syncer/workflow_registry.go:113:3: printf: (github.com/smartcontractkit/chainlink/v2/core/logger.Logger).Errorf does not support error-wrapping directive %w (govet)
Golang Lint	2024-11-07T17:00:34.8194827Z 		w.Logger.Errorf("failed to create engine: %w", err)
Golang Lint	2024-11-07T17:00:34.8195664Z 		^
Golang Lint	2024-11-07T17:00:34.8198600Z ##[error]core/services/workflows/syncer/workflow_registry.go:118:3: printf: (github.com/smartcontractkit/chainlink/v2/core/logger.Logger).Errorf does not support error-wrapping directive %w (govet)
Golang Lint	2024-11-07T17:00:34.8201398Z 		w.Logger.Errorf("failed to start hardcoded workflow: %w", err)
Golang Lint	2024-11-07T17:00:34.8202446Z 		^
Golang Lint	2024-11-07T17:00:34.8205640Z ##[error]core/services/workflows/syncer/workflow_registry.go:129:4: printf: (github.com/smartcontractkit/chainlink/v2/core/logger.Logger).Errorf does not support error-wrapping directive %w (govet)
Golang Lint	2024-11-07T17:00:34.8207763Z 			w.Logger.Errorf("could not close hardcoded engine: %w", err)
Golang Lint	2024-11-07T17:00:34.8208494Z 			^

**Why**: The linting errors include issues such as unused variables, improper formatting, and incorrect usage of logging functions.

Suggested fix:

Remove or use the unused wg field.
Format the file using goimports.
Remove unnecessary trailing newlines.
Correct the usage of Errorf by adding proper formatting directives or using the correct logging method.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

github-actions · 2024-11-07T14:58:07Z

Flaky Test Detector for `./go.mod` project has failed ❌

Ran new or updated tests between develop and 2744b82 (CAPPL-3-ph).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 51 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                             TestName                                     PassRatio  RunCount   Skipped
---------                                                               ---------                                    ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/workflows/store  Test_StoreDB_GetUnfinishedSteps              0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_GracefulEarlyTermination          0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_GetsNodeInfoDuringInitialization  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_TimesOutOldExecutions             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_MultiStepDependencies             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_ResumesPendingExecutions          0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_WrapsTargets                      0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestRetryableSuccessAfterRetries             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestRetryableErrorAfterMultipleRetries       0%         1          false

github-actions · 2024-11-07T16:01:58Z

Flaky Test Detector for `./go.mod` project has failed ❌

Ran new or updated tests between develop and a69ca05 (CAPPL-3-ph).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 44 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                             TestName                                     PassRatio  RunCount   Skipped
---------                                                               ---------                                    ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/workflows/store  Test_StoreDB_GetUnfinishedSteps              0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_ErrorsTheWorkflowIfAStepErrors    0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_GracefulEarlyTermination          0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_TimesOutOldExecutions             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestRetryableSuccessOnFirstAttempt           0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_ResumesPendingExecutions          0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_GetsNodeInfoDuringInitialization  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestRetryableCancellationHandling            0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_WrapsTargets                      0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestRetryableZeroMaxRetries                  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestParse_Graph                              0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_MultiStepDependencies             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestRetryableSuccessAfterRetries             0%         1          false

github-actions · 2024-11-07T17:10:16Z

Flaky Test Detector for `./go.mod` project has failed ❌

Ran new or updated tests between develop and 3fc7c0d (CAPPL-3-ph).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 61 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                             TestName                                     PassRatio  RunCount   Skipped
---------                                                               ---------                                    ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/workflows/store  Test_StoreDB_GetUnfinishedSteps              0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_GetsNodeInfoDuringInitialization  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_TimesOutOldExecutions             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_WrapsTargets                      0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_MultiStepDependencies             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_ResumesPendingExecutions          0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_ErrorsTheWorkflowIfAStepErrors    0%         1          false

justinkaseman and others added 6 commits November 5, 2024 14:52

Trigger build with CRON & KVSTORE standard capability binaries

dad2833

Comment to build plugins Updated Use goreleaser for compute WASM artifacts

@chainlink.contracts release v1.3.0 (#14812)

95dbcca

* Prep @chainlink/contracts v1.3.0 release * Update contracts release date for v1.3.0

fix: arm64 builds with goreleaser 2.4.x (#15110)

8800b27

* Revert "fix: pinning goreleaser version to fix builds (#15108)" This reverts commit 8bbff53. * fix: arm64 dist directory

Remove shallow checkout for changeset detection (#15113)

c3b5d37

removing dot seperator in path (#15120)

9ac0d6b

cedric-cordenier and others added 4 commits November 5, 2024 19:14

Add workflows

645858a

Add workflows

13474d1

Add missing workflows extra_files

cf987bf

Try optional copy tmp/workflows

5f7884a

justinkaseman added the build-publish Build and Publish image to SDLC label Nov 5, 2024

trigger build

96b0cfc

Create dummy registry

0d7ff26

cedric-cordenier force-pushed the CAPPL-3-ph branch from a316f57 to 0d7ff26 Compare November 6, 2024 11:58

Update workflow

c8d7b2f

cedric-cordenier force-pushed the CAPPL-3-ph branch from 6c60e67 to c8d7b2f Compare November 6, 2024 15:52

justinkaseman and others added 3 commits November 6, 2024 12:31

give hardcoded workflow a name + id

17680cf

Merge branch 'develop' into CAPPL-3-ph

fe4e07c

Bump common

444ffa0

cedric-cordenier force-pushed the CAPPL-3-ph branch from c03bf75 to 444ffa0 Compare November 7, 2024 11:52

cedric-cordenier added 2 commits November 7, 2024 12:11

Correct logger

399ed46

Incorporate KeyId into workflow

235d85b

cedric-cordenier force-pushed the CAPPL-3-ph branch from afd9d00 to 6eba838 Compare November 7, 2024 13:28

compress binary

a98566c

cedric-cordenier force-pushed the CAPPL-3-ph branch from 6eba838 to a98566c Compare November 7, 2024 14:00

cedric-cordenier force-pushed the CAPPL-3-ph branch from 2744b82 to cd8c663 Compare November 7, 2024 15:35

GetUnfinished fix

a69ca05

cedric-cordenier force-pushed the CAPPL-3-ph branch from cd8c663 to a69ca05 Compare November 7, 2024 15:43

feat: implement timeout

3fc7c0d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cappl 3 ph #15125

Cappl 3 ph #15125

patrickhuie19 commented Nov 5, 2024

github-actions bot commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 6, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

Cappl 3 ph #15125

Are you sure you want to change the base?

Cappl 3 ph #15125

Conversation

patrickhuie19 commented Nov 5, 2024

Requires

Supports

github-actions bot commented Nov 5, 2024 • edited Loading

Static analysis results are available

github-actions bot commented Nov 6, 2024 • edited Loading

AER Report: CI Core

1. Race condition detected in tests:[go_core_race_tests]

2. Foreign key constraint violation:[github.com/smartcontractkit/chainlink/v2/core/services/workflows/store]

3. Linting errors:[golangci-lint]

AER Report: Operator UI CI ran successfully ✅

github-actions bot commented Nov 7, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Failed Tests

github-actions bot commented Nov 7, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Failed Tests

github-actions bot commented Nov 7, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Failed Tests

github-actions bot commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 6, 2024 •

edited

Loading

Flaky Test Detector for `./go.mod` project has failed ❌

Flaky Test Detector for `./go.mod` project has failed ❌

Flaky Test Detector for `./go.mod` project has failed ❌