Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dual contract transmitter #15202

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Add dual contract transmitter #15202

wants to merge 13 commits into from
+244 −136

Conversation

george-dorin
Copy link
Contributor

@george-dorin george-dorin commented Nov 12, 2024 •
edited
Loading

-Add dual transmitter relay config
-Add dual contract transmitter
-Remove adaptive send

@george-dorin
-Remove adaptive send
03e20aa 
-Add dual transmitter relay config
-Add dual transmitter as contract transmitter
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@george-dorin george-dorin marked this pull request as ready for review November 13, 2024 13:29
@george-dorin george-dorin requested review from a team as code owners November 13, 2024 13:29
@github-actions GitHub Actions
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and bd51049 (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 217 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                 TestName                            PassRatio  RunCount   Skipped
---------                                                   ---------                           ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/job  TestRunner_Error_Callback_AsyncJob  0%         1          false

@george-dorin
Change tx.meta to pointers
0efa3be 
Send secondary tx even if primary fails
@github-actions GitHub Actions
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 0efa3be (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 217 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                 TestName                            PassRatio  RunCount   Skipped
---------                                                   ---------                           ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/job  TestRunner_Error_Callback_AsyncJob  0%         1          false

@github-actions GitHub Actions
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and b039e3a (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 218 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                 TestName                              PassRatio  RunCount   Skipped
---------                                                   ---------                             ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/job  TestRunner_Success_Callback_AsyncJob  50%        2          false

@george-dorin
Remove unused code
e8c9963 
Change DualTransmissionConfig to pointer
@github-actions GitHub Actions
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and e8c9963 (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 218 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                 TestName                              PassRatio           RunCount   Skipped
---------                                                   ---------                             ---------           ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/job  TestRunner_Success_Callback_AsyncJob  66.66666666666666%  3          false

@github-actions GitHub Actions
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 4985cf9 (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 66 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                       TestName              PassRatio  RunCount   Skipped
---------                                                         ---------             ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/ocrcommon  Test_DualTransmitter  0%         1          false

pavel-raykov
pavel-raykov reviewed Nov 14, 2024
View reviewed changes
core/services/ocrcommon/transmitter.go

func (t *ocr2FeedsDualTransmission) CreateEthTransaction(ctx context.Context, toAddress common.Address, payload []byte, txMeta *txmgr.TxMeta) error {
// Primary transmission
errPrimary := t.transmitter.CreateEthTransaction(ctx, toAddress, payload, txMeta)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to update CreateEthTransaction interface so that it can also be used below ? (instead of calling the underlying txm directly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-raykov pavel-raykov pavel-raykov left review comments

@dimriou dimriou dimriou approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@george-dorin @cedric-cordenier @dimriou @pavel-raykov