Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NONEVM-706][core] - TxExpirationRebroadcast config #15437

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

Farber98
Copy link
Contributor

@Farber98 Farber98 commented Nov 27, 2024

Description

Adds config to support TxExpirationRebroadcast feature within Solana TXM.

  • TxExpirationRebroadcast enables or disables transaction rebroadcast if expired. Expiration check is performed every ConfirmPollPeriod. A transaction is considered expired if the blockhash it was sent with is 150 blocks older than the latest blockhash.

Merge together with:

@Farber98 Farber98 changed the title [NONEVM-706][core] - TxExpiredRebroadcast config [NONEVM-706][core] - TxExpirationRebroadcast config Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/v2
Max Pass Ratio 100.00%
Test Run Count 6
Race Detection false
Excluded Tests TestChainComponents

Found Flaky Tests ❌

Category Total
Tests 381
Panicked Tests 0
Raced Tests 0
Flaky Tests 6
Flaky Test Ratio 1.57%
Runs 1,128
Passes 1,121
Failures 7
Skips 15
Pass Ratio 99.37%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestETHKeysController_ChainSuccess_ResetWithAbandon 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.4s Unknown
TestETHKeysController_Index_Errors 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.32s Unknown
TestETHKeysController_Index_NotDev 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.313333333s Unknown
TestPipelineRunsController_Show_HappyPath 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.363333333s Unknown
TestTransfersController_CreateSuccess_From 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.42s Unknown
TestTransfersController_CreateSuccess_From_WEI 33.33% false false false 3 1 2 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.443333333s Unknown

@Farber98 Farber98 marked this pull request as ready for review December 5, 2024 19:27
@Farber98 Farber98 requested review from a team as code owners December 5, 2024 19:27
@Farber98 Farber98 self-assigned this Dec 5, 2024
@cl-sonarqube-production
Copy link

@jmank88 jmank88 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into develop with commit b368079 Dec 19, 2024
174 of 175 checks passed
@jmank88 jmank88 deleted the nonevm-706-rebroadcast-expired-txes branch December 19, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants