Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support append & update capabilites mcms #15555

Closed
wants to merge 4 commits into from

Conversation

krehermann
Copy link
Contributor

refactor forwarder configuration changeset for mcms

refactor capability update changeset mcms

plumbing update nodes

update node with mcms

update node with mcms

Requires

Supports

@krehermann krehermann force-pushed the ks/refactor-capability-mutations-mcms branch from 50cde0d to 4336300 Compare December 6, 2024 21:27
@krehermann krehermann changed the title support mcms in ocr3 contract config changeset support append & update capabilites mcms Dec 7, 2024
refactor forwarder configuration changeset for mcms

refactor capability update changeset mcms

plumbing update nodes

update node with mcms

update node with mcms
@krehermann krehermann force-pushed the ks/refactor-capability-mutations-mcms branch from 4bdf4f3 to 0e5f9f2 Compare December 8, 2024 14:58
Copy link
Contributor

github-actions bot commented Dec 8, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Dec 8, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , lint , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/common/changeset, ubuntu-latest) , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/keystone/changeset, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Deployment Project / Report

1. Undefined method Remove in CapabilitiesRegistry:[go_core_race_tests]

Source of Error:
core/capabilities/webapi/trigger/trigger.go:262:21: h.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

2. Undefined method Remove in CapabilitiesRegistry:[go_core_race_tests]

Source of Error:
core/capabilities/webapi/target/target.go:63:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

3. Undefined method Remove in CapabilitiesRegistry:[go_core_race_tests]

Source of Error:
core/capabilities/compute/compute.go:282:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

4. Undefined function GenerateWorkflowID:[go_core_race_tests]

Source of Error:
core/services/workflows/syncer/handler.go:397:28: undefined: pkgworkflows.GenerateWorkflowID

Why: The function GenerateWorkflowID is not defined in the pkgworkflows package. This indicates that the function might be missing or incorrectly referenced.

Suggested fix: Verify that the GenerateWorkflowID function exists in the pkgworkflows package and is correctly imported. If it does not exist, implement the function or update the code to use an existing function.

5. Undefined method Remove in CapabilitiesRegistry:[go_core_race_tests]

Source of Error:
core/services/relay/evm/evm.go:267:33: r.capabilitiesRegistry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

6. Missing go.sum entry for chainlink-testing-framework/lib:[Clean Go Tidy & Generate]

Source of Error:
go: github.com/smartcontractkit/chainlink-testing-framework/lib@v1.50.17: missing go.sum entry for go.mod file; to add it:
	go mod download github.com/smartcontractkit/chainlink-testing-framework/lib
error: exit status 1

Why: The go.sum file is missing an entry for the chainlink-testing-framework/lib package, which is required for dependency management.

Suggested fix: Run go mod download github.com/smartcontractkit/chainlink-testing-framework/lib to update the go.sum file with the necessary entry.

7. Undefined method Remove in CapabilitiesRegistry:[go_core_tests_integration]

Source of Error:
core/capabilities/webapi/trigger/trigger.go:262:21: h.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

8. Undefined method Remove in CapabilitiesRegistry:[go_core_tests_integration]

Source of Error:
core/capabilities/webapi/target/target.go:63:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

9. Undefined method Remove in CapabilitiesRegistry:[go_core_tests_integration]

Source of Error:
core/capabilities/compute/compute.go:282:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

10. Undefined function GenerateWorkflowID:[go_core_tests_integration]

Source of Error:
core/services/workflows/syncer/handler.go:397:28: undefined: pkgworkflows.GenerateWorkflowID

Why: The function GenerateWorkflowID is not defined in the pkgworkflows package. This indicates that the function might be missing or incorrectly referenced.

Suggested fix: Verify that the GenerateWorkflowID function exists in the pkgworkflows package and is correctly imported. If it does not exist, implement the function or update the code to use an existing function.

11. Undefined method Remove in CapabilitiesRegistry:[go_core_tests_integration]

Source of Error:
core/services/relay/evm/evm.go:267:33: r.capabilitiesRegistry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

12. Undefined method Remove in CapabilitiesRegistry:[go_core_ccip_deployment_tests]

Source of Error:
core/capabilities/webapi/trigger/trigger.go:262:21: h.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

13. Undefined method Remove in CapabilitiesRegistry:[go_core_ccip_deployment_tests]

Source of Error:
core/capabilities/webapi/target/target.go:63:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

14. Undefined method Remove in CapabilitiesRegistry:[go_core_ccip_deployment_tests]

Source of Error:
core/capabilities/compute/compute.go:282:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

15. Undefined function GenerateWorkflowID:[go_core_ccip_deployment_tests]

Source of Error:
core/services/workflows/syncer/handler.go:397:28: undefined: pkgworkflows.GenerateWorkflowID

Why: The function GenerateWorkflowID is not defined in the pkgworkflows package. This indicates that the function might be missing or incorrectly referenced.

Suggested fix: Verify that the GenerateWorkflowID function exists in the pkgworkflows package and is correctly imported. If it does not exist, implement the function or update the code to use an existing function.

16. Undefined method Remove in CapabilitiesRegistry:[go_core_ccip_deployment_tests]

Source of Error:
core/services/relay/evm/evm.go:267:33: r.capabilitiesRegistry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

17. Undefined method Remove in CapabilitiesRegistry:[go_core_tests]

Source of Error:
core/capabilities/webapi/trigger/trigger.go:262:21: h.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

18. Undefined method Remove in CapabilitiesRegistry:[go_core_tests]

Source of Error:
core/capabilities/webapi/target/target.go:63:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

19. Undefined method Remove in CapabilitiesRegistry:[go_core_tests]

Source of Error:
core/capabilities/compute/compute.go:282:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

20. Undefined function GenerateWorkflowID:[go_core_tests]

Source of Error:
core/services/workflows/syncer/handler.go:397:28: undefined: pkgworkflows.GenerateWorkflowID

Why: The function GenerateWorkflowID is not defined in the pkgworkflows package. This indicates that the function might be missing or incorrectly referenced.

Suggested fix: Verify that the GenerateWorkflowID function exists in the pkgworkflows package and is correctly imported. If it does not exist, implement the function or update the code to use an existing function.

21. Undefined method Remove in CapabilitiesRegistry:[go_core_tests]

Source of Error:
core/services/relay/evm/evm.go:267:33: r.capabilitiesRegistry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

22. Undefined method Remove in CapabilitiesRegistry:[go_core_fuzz]

Source of Error:
core/capabilities/webapi/trigger/trigger.go:262:21: h.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

23. Undefined method Remove in CapabilitiesRegistry:[go_core_fuzz]

Source of Error:
core/capabilities/webapi/target/target.go:63:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method available in the CapabilitiesRegistry type.

24. Undefined method Remove in CapabilitiesRegistry:[go_core_fuzz]

Source of Error:
core/capabilities/compute/compute.go:282:20: c.registry.Remove undefined (type "github.com/smartcontractkit/chainlink-common/pkg/types/core".CapabilitiesRegistry has no field or method Remove)

Why: The CapabilitiesRegistry type from the chainlink-common package does not have a method named Remove. This indicates a mismatch between the expected interface and the actual implementation.

Suggested fix: Ensure that the CapabilitiesRegistry type in the chainlink-common package includes the Remove method or update the code to use the correct method

@krehermann krehermann closed this Dec 10, 2024
@krehermann krehermann deleted the ks/refactor-capability-mutations-mcms branch December 10, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant