Granular MCMS optional CCIP chain contract changesets #15651
Conversation
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
connorwstein
changed the title
connorwstein
changed the title
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
| }, | ||
| } | ||
| } | ||
|
|
||
| type PromoteAllCandidatesChangesetConfig struct { |
There was a problem hiding this comment.
made promote/add/setcandidate all support multiple DONs at once. Relevant for signer changes as an example
| EncodableChainConifg chainconfig.ChainConfig | ||
| } | ||
|
|
||
| type UpdateChainConfigConfig struct { |
There was a problem hiding this comment.
new changeset here for managing chain config. Parameterizing the readers in particular will allow us to test heterogeneous chain support
| ) | ||
|
|
||
| var ( | ||
| _ deployment.ChangeSet[UpdateOnRampDestsConfig] = UpdateOnRampsDests |
There was a problem hiding this comment.
collectively these changesets allow for:
- Adding/removing lanes and chains
- Changing fee config
- Promoting lanes to real router
connorwstein
changed the title
| _ deployment.ChangeSet[UpdateOffRampSourcesConfig] = UpdateOffRampSources | ||
| _ deployment.ChangeSet[UpdateRouterRampsConfig] = UpdateRouterRamps | ||
| _ deployment.ChangeSet[UpdateFeeQuoterDestsConfig] = UpdateFeeQuoterDests | ||
| _ deployment.ChangeSet[SetOCR3OffRampConfig] = SetOCR3OffRamp |
There was a problem hiding this comment.
note SetOCR3OffRamp technically has test coverage because its used in the env setup. Can add an explicit unit test in a follow up.
connorwstein
deleted the
CCIP-4567-granular-mcms-optional-changsets-for-chain-contracts
branch
Replacing the add chain/add lane with more granular/flexible changesets which are MCMS optional. Flexibility is needed for when we want to test new chains/lanes via test router. Also moving towards a
Validate(e deployment.Environment) errorpattern to standardize (loading the state twice not a particularly big deal) and I added an ValidateOwnership function for general use with MCMS optional changesets.Follow up work: replace AddLanes with a composition of chain contract changesets and add a AddNewChain test.