Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRASH test debug logging for config poller in staging #15775

Closed
wants to merge 3 commits into from

Conversation

samsondav
Copy link
Collaborator

Requires

Supports

…unofficial release to unblock data streams for testing purposes

Signed-off-by: bwest981 <3317895+Bwest981@users.noreply.github.com>
@samsondav samsondav added build-test-image Will build the e2e test image in integration-tests workflow for PRs build-publish Build and Publish image to SDLC labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , GolangCI Lint (.) , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Flakeguard Deployment Project , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , lint , SonarQube Scan , Flakey Test Detection

1. Integer overflow conversion error: Golang Lint

Source of Error:
Golang Lint (.) 2024-12-19T19:16:05.6365784Z ##[error]core/services/llo/delegate.go:149:56: G115: integer overflow conversion int -> int32 (gosec)
Golang Lint (.) 2024-12-19T19:16:05.6367536Z 				Database: d.cfg.NewOCR3DB(int32(i)),
Golang Lint (.) 2024-12-19T19:16:05.6368552Z 				 ^

Why: The error is caused by a potential integer overflow when converting an int to an int32. This can happen if the int value exceeds the range that can be represented by an int32.

Suggested fix: Ensure that the value being converted to int32 is within the range of int32 before performing the conversion. You can add a check to validate the value or handle the overflow case appropriately.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@samsondav samsondav force-pushed the config_bluegreen_debugging branch from efb3b9f to 848466c Compare December 19, 2024 17:02
Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

The OCR3 database must be scoped to each instance, not to the job,
otherwise we can restore the wrong config on node restart.
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@samsondav samsondav closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-publish Build and Publish image to SDLC build-test-image Will build the e2e test image in integration-tests workflow for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants