Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keystone): support multiple OCR3 contracts #15803

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat(keystone): support multiple OCR3 contracts #15803

wants to merge 5 commits into from
+221 −12

Conversation

MStreet3
Copy link
Contributor

@MStreet3 MStreet3 commented Dec 23, 2024 •
edited
Loading

It is possible to deploy multiple OCR contracts per chain for workflow dons. This PR:

  • enables changesets to configure a specific OCR contract by passing an address
  • makes it an error to attempt to configure the OCR3 contract for a chain if there are multiple OCR contracts and no address specified

Requires

Supports

@MStreet3 MStreet3 requested review from a team as code owners December 23, 2024 20:56
@MStreet3 MStreet3 force-pushed the cappl-404/ocr3-multiple-contracts branch from aacfe02 to 9682e41 Compare December 23, 2024 20:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

bolekk
bolekk reviewed Dec 23, 2024
View reviewed changes
deployment/keystone/changeset/configure_contracts.go Outdated Show resolved Hide resolved
deployment/keystone/changeset/deploy_ocr3.go Outdated Show resolved Hide resolved
deployment/keystone/changeset/internal/deploy.go Outdated Show resolved Hide resolved
deployment/keystone/changeset/internal/state.go Outdated Show resolved Hide resolved
@MStreet3 MStreet3 force-pushed the cappl-404/ocr3-multiple-contracts branch from 9682e41 to 0cdba03 Compare December 23, 2024 21:36
@MStreet3 MStreet3 force-pushed the cappl-404/ocr3-multiple-contracts branch from 9bad051 to 56c1438 Compare December 23, 2024 22:17
@MStreet3 MStreet3 requested a review from bolekk December 23, 2024 22:17
@MStreet3 MStreet3 enabled auto-merge December 23, 2024 22:22
bolekk
bolekk previously approved these changes Dec 23, 2024
View reviewed changes
deployment/keystone/changeset/internal/deploy.go Outdated Show resolved Hide resolved
deployment/keystone/changeset/internal/deploy.go Outdated Show resolved Hide resolved
@MStreet3 MStreet3 requested a review from bolekk December 24, 2024 13:20
@MStreet3 MStreet3 force-pushed the cappl-404/ocr3-multiple-contracts branch from e4990cd to 4d594bd Compare December 24, 2024 13:29
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk Awaiting requested review from bolekk

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MStreet3 @bolekk