Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump libocr and update affected areas #9350

Merged
merged 1 commit into from
May 31, 2023
Merged

bump libocr and update affected areas #9350

merged 1 commit into from
May 31, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented May 25, 2023 •
edited
Loading

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 mentioned this pull request May 25, 2023
Merged
@jmank88 jmank88 force-pushed the BCF-2274-bump-libocr-add-errs branch 3 times, most recently from b1cc89e to af1f4b2 Compare May 25, 2023 20:41
@jmank88 jmank88 marked this pull request as ready for review May 25, 2023 20:45
@jmank88 jmank88 requested a review from a team as a code owner May 25, 2023 20:45
@jmank88 jmank88 requested review from krehermann and aalu1418 May 25, 2023 20:49
@jmank88
Copy link
Contributor Author

jmank88 commented May 25, 2023

Solana smoke test is failing because the integration tests in the solana repo indirectly import an older version of starknet 😕

@jmank88
Copy link
Contributor Author

jmank88 commented May 25, 2023

Solana smoke test is failing because the integration tests in the solana repo indirectly import an older version of starknet confused

Perhaps this will help: smartcontractkit/chainlink-solana#516

@jmank88 jmank88 mentioned this pull request May 25, 2023
Closed
patrickhuie19
patrickhuie19 previously approved these changes May 25, 2023
View reviewed changes
@jmank88 jmank88 mentioned this pull request May 26, 2023
Closed
samsondav
samsondav previously approved these changes May 30, 2023
View reviewed changes
@jmank88 jmank88 dismissed stale reviews from samsondav and patrickhuie19 via 8abba47 May 31, 2023 02:03
@jmank88 jmank88 force-pushed the BCF-2274-bump-libocr-add-errs branch 5 times, most recently from c0e0b4d to 2afefd6 Compare May 31, 2023 02:29
@jmank88 jmank88 mentioned this pull request May 31, 2023
Merged
@jmank88
Copy link
Contributor Author

jmank88 commented May 31, 2023 •
edited
Loading

I don't understand why the solana integration test are using chainlink-relay@v0.1.7-0.20230530222821-30d787a10087 😕
Edit: I think I figured it out.

@jmank88 jmank88 force-pushed the BCF-2274-bump-libocr-add-errs branch from 2afefd6 to ce21720 Compare May 31, 2023 02:48
@jmank88 jmank88 force-pushed the BCF-2274-bump-libocr-add-errs branch from ce21720 to 3f97b05 Compare May 31, 2023 02:58
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@archseer archseer merged commit 9527151 into develop May 31, 2023
@archseer archseer deleted the BCF-2274-bump-libocr-add-errs branch May 31, 2023 07:16
@jmank88 jmank88 mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 left review comments

@samsondav samsondav samsondav left review comments

@krehermann krehermann Awaiting requested review from krehermann

@aalu1418 aalu1418 Awaiting requested review from aalu1418

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmank88 @archseer @samsondav @patrickhuie19 @austinborn