Move EVM config ocr and ocr2 #9606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
…e_EVM_ocr_and_ocr2_config
…e_EVM_ocr_and_ocr2_config
…e_EVM_ocr_and_ocr2_config # Conflicts: # core/chains/evm/config/v2/chain_scoped.go
george-dorin
requested review from
connorwstein,
samsondav and
prashantkumar1982
as code owners
| @@ -220,6 +228,18 @@ func (c *ChainScoped) EvmGasTipCapMinimum() *assets.Wei { | |||
| return c.cfg.GasEstimator.TipCapMin | |||
| } | |||
|
|
|||
| func (c *ChainScoped) EvmHeadTrackerHistoryDepth() uint32 { | |||
There was a problem hiding this comment.
@george-dorin Rebase error? These have been removed in a PR that I merged recently.
cedric-cordenier
previously approved these changes
Jun 15, 2023
…e_EVM_ocr_and_ocr2_config # Conflicts: # core/chains/evm/config/config.go # core/chains/evm/config/v2/chain_scoped.go
jmank88
reviewed
Jun 15, 2023
| @@ -1124,3 +1110,5 @@ func TestRunner_Error_Callback_AsyncJob(t *testing.T) { | |||
| require.Eventually(t, func() bool { return eiNotifiedOfDelete }, 5*time.Second, 10*time.Millisecond, "expected external initiator to be notified of deleted job") | |||
| } | |||
| } | |||
|
|
|||
| func ptr[T any](t T) *T { return &t } | |||
There was a problem hiding this comment.
Hoping we can drop these in two release 🤞
golang/go#45624
jmank88
reviewed
Jun 15, 2023
jmank88
reviewed
Jun 15, 2023
…e_EVM_ocr_and_ocr2_config
|
SonarQube Quality Gate
|
cedric-cordenier
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCRandOCR2EVM chain scoped config