Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{strip}..{/strip} strip spaces between words in this case #177

Closed
yourchoice opened this issue Feb 5, 2016 · 6 comments
Closed

{strip}..{/strip} strip spaces between words in this case #177

yourchoice opened this issue Feb 5, 2016 · 6 comments

Comments

@yourchoice
Copy link

{strip}
    <h1>Text <em>italic</em></h1>
{/strip}

This sequence output "Textitalic" without space.

@yourchoice yourchoice changed the title {strip}..{/strip} stri and spaces between words in this case {strip}..{/strip} strip spaces between words in this case Feb 5, 2016
@yourchoice yourchoice reopened this Feb 5, 2016
@ophian
Copy link

ophian commented Feb 8, 2016

Did you see a8f8efd?
Does that fix it or is that the problem, and with which version?

@yourchoice
Copy link
Author

3.1.30-dev/28

@uwetews
Copy link
Contributor

uwetews commented Feb 9, 2016

3.1.30-dev/28 does output it with space as it should at my place

@yourchoice
Copy link
Author

Hi again,

Yes, seems to be a particular case. I tried to simulate.

This working well (let the space between words):

<h2>Word1 <em>Word2</em></h2>

This not:

<h2>{'Word1'} <em>Word2</em></h2>

For second can by any smarty var.

@uwetews
Copy link
Contributor

uwetews commented Feb 10, 2016

The fix is now in the master branch and will later be included in 3.1.30

Smarty now does keep the space when the tag does create output.

Just as test case

<h2>{counter} <em>Word2</em></h2>

does keep the space

<h2>{counter assign=foo} <em>Word2</em></h2>

does not

@uwetews uwetews closed this as completed Feb 10, 2016
uwetews added a commit that referenced this issue Feb 10, 2016
@yourchoice
Copy link
Author

Hi,

Sorry, this issue need reopen.

There exists another case:

<i class="fa fa-archive"></i> {#archived_menu#|mb_ucfirst}
Same thing, there space is striped.

I think you resolve just for case when a smarty var precedes an html tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants