Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- bugfix {foreach} avoid using empty() #287

Closed
wants to merge 1 commit into from
Closed

- bugfix {foreach} avoid using empty() #287

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 9, 2016

Using empty() an an object will always return false. So the foreachelse
block will never be reached even with an iterator with zero entries.
Using the total count to determine an empty object.

Using empty() an an object will always return false. So the foreachelse
block will never be reached even with an iterator with zero entries.
Using the total count to determine an empty object.
uwetews added a commit that referenced this pull request Sep 9, 2016
@uwetews
Copy link
Contributor

uwetews commented Sep 9, 2016

This is now fixed in the master branch.
Because of execution time optimization I implemented a little bit different solution

@uwetews uwetews closed this Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant