Fix PHP8.1 deprecation warnings on null string in modifiers #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't we do this recently in a huge PR? Or did that not include modifiers & functions? It seems inefficient to do every modifier/function separately like this and d304d34 and more. On the other hand, I don't even run 8.1 yet, so I'm not going to fix all of them =) so you can safely ignore me. |
|
I didn't see it on |
|
I added some more casts to modifiers that were probably left out previously, it should all be good now :) |
AdrienPoupa
changed the title
Prevents E_DEPRECATED: mb_strlen(): Passing null to parameter smarty-php#1 ($string) of type string is deprecated
AdrienPoupa
changed the title
AdrienPoupa
changed the title
|
We've been using this in production for some time now, it works fine. We would love to see it merged and released so we can drop our internal fork :) |
|
No problem! Thank you for your contribution. |
|
Thanks for the merge! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if one is calling
|truncateon null, it triggersE_DEPRECATED: mb_strlen(): Passing null to parameter #1 ($string) of type string is deprecatedon PHP 8.1.This is expected, but given the modifier accepts null we may as well return an empty string before calling the function.