Skip to content
This repository has been archived by the owner on Nov 8, 2017. It is now read-only.

Broken with Atom's new shadow DOM #99

Closed
danielmahon opened this issue Dec 22, 2014 · 5 comments
Closed

Broken with Atom's new shadow DOM #99

danielmahon opened this issue Dec 22, 2014 · 5 comments
Milestone

Comments

@danielmahon
Copy link

Git merge "changes" do not appear when the Shadow DOM is enabled in Atom.io settings. Only the headings "//our changes, //their changes" are visible.

@smashwilson
Copy link
Owner

Hmm, I think I tried it out earlier when the shadow DOM was first introduced and noticed similar breakage. I didn't investigate further then because I believe an API or two that I wanted to use were still in development. I'll have a look the next time I spend a day on this, thanks 👾

@smashwilson smashwilson added this to the 1.2.9 milestone Dec 28, 2014
@smashwilson
Copy link
Owner

Er, this is now rather more urgent. Fortunately I believe #93 might address this, but I'll need to test. I should have time in a day or so.

@smashwilson
Copy link
Owner

Well well. #93 ended up being more work than I was hoping it would be. Let's see if I can fix just the shadow DOM bits, instead, to unbreak things quickly.

@smashwilson smashwilson mentioned this issue Jan 15, 2015
@smashwilson smashwilson modified the milestones: 1.2.9, 1.2.10 Jan 18, 2015
@smashwilson
Copy link
Owner

Back in business!

screen shot 2015-01-19 at 10 57 14 am

Still a few visual issues, but we're up and running again. The next release should be operable again.

@danielmahon
Copy link
Author

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants