Skip to content
This repository has been archived by the owner on Nov 8, 2017. It is now read-only.

Install the overlay. #93

Merged
merged 8 commits into from
Jan 19, 2015
Merged

Install the overlay. #93

merged 8 commits into from
Jan 19, 2015

Conversation

smashwilson
Copy link
Owner

Use overlay decorations once they land in a release 💖

Fixes #92.

}

atom-overlay, atom-overlay::shadow {
// width: 100%;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do this: it would apply to all overlays, everywhere.

I'll need to send a PR to Atom adding an option to apply custom classes to each created overlay.

@smashwilson
Copy link
Owner Author

Er, this doesn't quite work.

screen shot 2015-01-15 at 1 24 41 pm

Part of this is not being able to apply a width: 100% style to the overlay DOM elements, which contain the merge-conflict controls. But I'm not sure why it isn't tracking the position properly. If I understand overlays, they should position themselves directly over the decorated text.

@smashwilson
Copy link
Owner Author

Nope! By default, overlays are just below the marked text, for things like the autocomplete box. I'm using a negative margin to put them in the right place:

screen shot 2015-01-19 at 10 43 58 am

There are still a few positioning issues with certain styles. It seems like the stylesheet can cause the vertical scrollbar width to not be accurate:

screen shot 2015-01-19 at 10 45 40 am

@smashwilson
Copy link
Owner Author

Good enough for now! Much less wonky than it was.

@smashwilson smashwilson changed the title [wip] Install the overlay. Install the overlay. Jan 19, 2015
smashwilson added a commit that referenced this pull request Jan 19, 2015
@smashwilson smashwilson merged commit 32f56b9 into master Jan 19, 2015
@smashwilson smashwilson deleted the overlay-decoration branch January 19, 2015 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use overlay decorations
1 participant