This repository has been archived by the owner on Nov 8, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConflictParser
has outgrown its initial implementation. Because diff3-style conflicts can recursively contain sub-merge conflicts, matching with a single regular expression and advancing through its match groups won't be enough: we need something that can recurse with it.What I'm attempting instead is to use a simpler regexp to scan for lines that look like the beginning of a conflict, then invoking a stateful parser that advances row-by-row and descends into a recursive call if the
BASE
side looks like a conflict itself.