This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Refactor polaris-button to ES6 class #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakumar-kailasam
suggested changes
Aug 7, 2019
addon/components/polaris-button.js
Outdated
| ariaExpandedValue: computed('ariaExpanded', function() { | ||
| let ariaExpanded = this.get('ariaExpanded'); | ||
| @computed('ariaExpanded') | ||
| get ariaExpandedValue() { |
There was a problem hiding this comment.
this could probably go directly on the template. If an attribute is empty, it won't be rendered anyway.
addon/components/polaris-button.js
Outdated
|
|
||
| @computed('submit') | ||
| get type() { | ||
| return this.submit === true ? 'submit' : 'button'; |
There was a problem hiding this comment.
how do you feel about moving this to the template to help shorten this class?
addon/components/polaris-button.js
Outdated
| * button element's event object as the first parameter. | ||
| */ | ||
| @action | ||
| invokeMouseAction(actionName) { |
There was a problem hiding this comment.
I've never realised that we don't send back the event. What if someone wants the event? (to prevent bubbling)
|
good feedback Siva...updated |
sivakumar-kailasam
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's here
externalClasses- going forward an HTMLclassattribute can be usedNOTE
Tests are failing on beta & canary, likely related to ember-decorators/ember-decorators#451