Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: don't announce the VIP on acquire failure
I noticed that while looking at siderolabs#8493, but I don't know if this problem actually happened in real life. If acquiring a VIP fails (which can only fail for Equinix/HCloud, not L2 ARP announce), we should not set the leader flag, as it would make the controller announce the IP, while it shouldn't do that. If this call fails, there's no matching call to de-announce on failure. The bug would show up as two nodes having same VIP assigned on the host. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
- Loading branch information