Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow topicSeparator to be changed #89

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Allow topicSeparator to be changed #89

merged 1 commit into from
Mar 29, 2022

Conversation

wbarnha
Copy link
Contributor

@wbarnha wbarnha commented Mar 28, 2022

I really like this library, my only issue is that we need pub/sub payloads to be formatted [Topic, 'b\0', Message]. Would you be willing to allow this functionality to change so that I could call something like ZmqPubConnection.topicSeparator = b'new_sep'?

@smira
Copy link
Owner

smira commented Mar 29, 2022

@wbarnha lgtm, would you mind squashing your commits?

@wbarnha
Copy link
Contributor Author

wbarnha commented Mar 29, 2022

Done, thanks for getting back to me quickly.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 89.078% when pulling 7bd075e on wbarnha:topic_separator_attr into 678522b on smira:master.

@smira smira merged commit ac1f6a6 into smira:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants