Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazily resolve proxy environment variables #1066

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

lauzadis
Copy link
Contributor

This PR updates the EnvironmentProxySelector to lazily resolve environment variables rather than immediately parsing them during initialization

Issue #

Resolves awslabs/aws-sdk-kotlin#1281

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner April 12, 2024 15:57
Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we add a new test verifying that junk values in the vars/props are ignored when overriding the proxy selector in HTTP client config?

@lauzadis
Copy link
Contributor Author

@ianbotsf I added a test but it required making EnvironmentProxySelector public with an @InternalApi annotation because the tests are in a separate module, do you think it's worth keeping this way?

@lauzadis lauzadis merged commit b211771 into main Apr 15, 2024
13 checks passed
@lauzadis lauzadis deleted the fix-environment-proxy-selector branch April 15, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Customize Proxy or Create Client when Environment Variables are Invalid
3 participants