Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty* comparison #1102

Merged
merged 13 commits into from
Jun 18, 2024
Merged

fix: empty* comparison #1102

merged 13 commits into from
Jun 18, 2024

Conversation

0marperez
Copy link
Contributor

@0marperez 0marperez commented Jun 17, 2024

Issue #

Description of changes

This PR fixes the way that EmptyAttributes, EmptyHeaders, Empty (Http Body) and EmptyDeferredHeaders are compared to their non Empty* data types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0marperez 0marperez added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Jun 17, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

@0marperez 0marperez marked this pull request as ready for review June 17, 2024 20:24
@0marperez 0marperez requested a review from a team as a code owner June 17, 2024 20:24
@0marperez 0marperez changed the title fix: empty attributes & headers comparison fix: empty attributes/headers comparison Jun 17, 2024
@0marperez 0marperez changed the title fix: empty attributes/headers comparison fix: empty attributes comparison & empty headers comparison Jun 17, 2024
@0marperez 0marperez changed the title fix: empty attributes comparison & empty headers comparison fix: empty* comparison Jun 18, 2024
Copy link

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
http-jvm.jar 108,782 108,106 676 0.63%
runtime-core-jvm.jar 883,342 883,226 116 0.01%

@0marperez 0marperez merged commit 8209f96 into main Jun 18, 2024
15 checks passed
@0marperez 0marperez deleted the business-metrics branch June 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants