Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create JMESPATH flattenIfPossible functions for Lists #1169

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

0marperez
Copy link
Contributor

@0marperez 0marperez commented Oct 29, 2024

Issue #

N/A

Description of changes

-Add JMESPath flatten wrappers for lists.
-Fixes:
Assignment type mismatch: actual type is 'Collection<*>, but 'List<*>' was expected.
During operationContextParams JMESPath code generation.

Testing

Tested locally by building smithy-kotlin and generating all SDK services.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0marperez 0marperez added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Oct 29, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

@0marperez 0marperez marked this pull request as ready for review October 29, 2024 19:50
@0marperez 0marperez requested a review from a team as a code owner October 29, 2024 19:50

This comment has been minimized.

Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good but let's also add tests for this.

This comment has been minimized.

This comment has been minimized.

Copy link

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
runtime-core-jvm.jar 811,179 811,080 99 0.01%

@0marperez 0marperez merged commit a4734c7 into main Dec 16, 2024
16 checks passed
@0marperez 0marperez deleted the jmespath-flatten branch December 16, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants