chore: upgrade smithy to 1.13 #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
requested review from
kggilmer and
ianbotsf
and removed request for
kggilmer
kggilmer
approved these changes
Nov 1, 2021
| @@ -42,6 +42,8 @@ val generateSdkRuntimeVersion by tasks.registering { | |||
| // this keeps us from having to manually change version numbers in multiple places | |||
| val resourcesDir = "$buildDir/resources/main/software/amazon/smithy/kotlin/codegen/core" | |||
| val versionFile = file("$resourcesDir/sdk-version.txt") | |||
| val gradlePropertiesFile = rootProject.file("gradle.properties") | |||
| inputs.file(gradlePropertiesFile) | |||
There was a problem hiding this comment.
question
This is to determine build dirty-ness or something else?
There was a problem hiding this comment.
Yes. When we upgrade the version the generated version is not changing because it is already generated. This generally seems to only affect local development because CI is a fresh build. The fix is to clean and rebuild (or manually delete the file).
ianbotsf
approved these changes
Nov 1, 2021
.github/pull_request_template.md
Outdated
Comment on lines
10
to
14
| ## Scope | ||
| <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> | ||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
|
|
There was a problem hiding this comment.
Correctness: Unrelated to upgrading Smithy. This should be moved to a separate commit.
aajtodd
force-pushed
the
chore-upgrade-smithy
branch
from
3b40438 to
71e10ea
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.