feat(codegen): generate paginators and waiters with default parameters for all optional inputs #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
approved these changes
Sep 25, 2023
| @@ -124,6 +116,12 @@ class PaginatorGenerator : KotlinIntegration { | |||
| """.trimIndent() | |||
| val docReturn = "@return A [kotlinx.coroutines.flow.Flow] that can collect [${outputSymbol.name}]" | |||
|
|
|||
| val inputParameter = if (paginationInfo.input.hasAllOptionalMembers) { | |||
| writer.format("initialRequest: #1T = #1T{}", inputSymbol) | |||
There was a problem hiding this comment.
nit (style): #1T { }
If you think it's a good suggestion, also applies to the same change in waiters
ianbotsf
approved these changes
Sep 25, 2023
0marperez
approved these changes
Sep 25, 2023
aajtodd
force-pushed
the
fix-signatures
branch
from
aae077d to
93c7e51
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
n/a
Description of changes
nullwhen no index is found (indexOfreturns-1when not found, our test logic was predicating offnulland silently passing tests that should fail).visibilitybuild setting #951 added API settings for internal vs external visibility but we missed paginators and waiters as part of this, updated codegen to respect the visibility for generated paginators and waiters.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.