refactor: xml content type header renderer to be overridable #977
Conversation
0marperez
added
the
no-changelog
| renderContentTypeHeader(ctx, op, writer) | ||
| } | ||
|
|
||
| protected open fun renderContentTypeHeader(ctx: ProtocolGenerator.GenerationContext, op: OperationShape, writer: KotlinWriter) { | ||
| val resolver = getProtocolHttpBindingResolver(ctx.model, ctx.service) |
There was a problem hiding this comment.
Nit: Pass resolver through to renderContentTypeHeader.
There was a problem hiding this comment.
We don't do that elsewhere FWIW (e.g.renderUri below)
| renderContentTypeHeader(ctx, op, writer) | ||
| } | ||
|
|
||
| protected open fun renderContentTypeHeader(ctx: ProtocolGenerator.GenerationContext, op: OperationShape, writer: KotlinWriter) { | ||
| val resolver = getProtocolHttpBindingResolver(ctx.model, ctx.service) |
There was a problem hiding this comment.
We don't do that elsewhere FWIW (e.g.renderUri below)
0marperez
force-pushed
the
missing-content-type
branch
from
b21fee1 to
cae26c5
Compare
| */ | ||
| fun OperationShape.inputIsUnionShape(model: Model): Boolean { | ||
| val reqShape = model.expectShape<StructureShape>(input.get()) | ||
| return reqShape.isUnionShape |
There was a problem hiding this comment.
fix: This is always false. (1) operation inputs MUST be a structure shape and (2) you've already pulled out a StructureShape so it can't be a UnionShape at this point.
I don't think you even need this function though as the other function introduced appears to do what you want/need.
| @@ -193,6 +192,15 @@ val Shape.isSparse: Boolean | |||
| val Shape.isStreaming: Boolean | |||
| get() = hasTrait<StreamingTrait>() | |||
|
|
|||
| /** | |||
| * Returns boolean indicating if operation input is union shaped | |||
There was a problem hiding this comment.
fix: It returns true if the operation input has an explicit HTTP payload member that is a union shape.
The input shape itself can never be a union in smithy.
|
Kudos, SonarCloud Quality Gate passed!
|
Issue #
Description of changes
-The part of the code that renders the xml content type header is made overridable
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.