Fix linting issues

smithy-lang · Jan 5, 2023 · 333bbcf · 333bbcf
1 parent 35d7419
commit 333bbcf
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 19 deletions.
diff --git a/...on/src/main/kotlin/software/amazon/smithy/rust/codegen/server/python/smithy/PythonType.kt b/...on/src/main/kotlin/software/amazon/smithy/rust/codegen/server/python/smithy/PythonType.kt
@@ -126,7 +126,9 @@ fun RustType.pythonType(): PythonType =
         is RustType.Box -> this.member.pythonType()
         is RustType.Dyn -> this.member.pythonType()
         is RustType.Opaque -> PythonType.Opaque(this.name, this.namespace)
-        is RustType.MaybeConstrained -> this.member.pythonType() // TODO: How to handle this?
+        // TODO(Constraints): How to handle this?
+        // Revisit as part of https://github.com/awslabs/smithy-rs/issues/2114
+        is RustType.MaybeConstrained -> this.member.pythonType()
     }
 
 /**
@@ -167,6 +169,6 @@ fun PythonType.render(fullyQualified: Boolean = true): String {
  * Renders [PythonType] with proper escaping for Docstrings.
  */
 fun PythonType.renderAsDocstring(): String =
-    this.render().
-        replace("[", "\\[").
-        replace("]", "\\]")
+    this.render()
+        .replace("[", "\\[")
+        .replace("]", "\\]")
diff --git a/...n/smithy/rust/codegen/server/python/smithy/customizations/PythonServerCodegenDecorator.kt b/...n/smithy/rust/codegen/server/python/smithy/customizations/PythonServerCodegenDecorator.kt
@@ -111,9 +111,9 @@ class PyProjectTomlDecorator : ServerCodegenDecorator {
                 ).toMap(),
                 "tool" to listOfNotNull(
                     "maturin" to listOfNotNull(
-                        "python-source" to "python"
+                        "python-source" to "python",
                     ).toMap(),
-                ).toMap()
+                ).toMap(),
             )
             writeWithNoFormatting(TomlWriter().write(config))
         }
@@ -148,7 +148,7 @@ from .$libName import *
 __doc__ = $libName.__doc__
 if hasattr($libName, "__all__"):
     __all__ = $libName.__all__
-                """.trimIndent()
+                """.trimIndent(),
             )
         }
     }

diff --git a/.../amazon/smithy/rust/codegen/server/python/smithy/generators/PythonApplicationGenerator.kt b/.../amazon/smithy/rust/codegen/server/python/smithy/generators/PythonApplicationGenerator.kt
@@ -342,16 +342,18 @@ class PythonApplicationGenerator(
                 val output = PythonType.Opaque("${operationName}Output", "crate::output")
                 val context = PythonType.Opaque("Ctx")
                 val returnType = PythonType.Union(listOf(output, PythonType.Awaitable(output)))
-                val handler = PythonType.Union(listOf(
-                    PythonType.Callable(
-                        listOf(input, context),
-                        returnType
+                val handler = PythonType.Union(
+                    listOf(
+                        PythonType.Callable(
+                            listOf(input, context),
+                            returnType,
+                        ),
+                        PythonType.Callable(
+                            listOf(input),
+                            returnType,
+                        ),
                     ),
-                    PythonType.Callable(
-                        listOf(input),
-                        returnType
-                    )
-                ))
+                )
 
                 rustTemplate(
                     """

diff --git a/...mithy/rust/codegen/server/python/smithy/generators/PythonTypeInformationGenerationTest.kt b/...mithy/rust/codegen/server/python/smithy/generators/PythonTypeInformationGenerationTest.kt
@@ -37,10 +37,10 @@ internal class PythonTypeInformationGenerationTest {
 
         // Constructor signature
         result.shouldContain("/// :param bar str:")
-        result.shouldContain("/// :param baz typing.Optional[int]:")
+        result.shouldContain("/// :param baz typing.Optional\\[int\\]:")
 
         // Field types
         result.shouldContain("/// :type str:")
-        result.shouldContain("/// :type typing.Optional[int]:")
+        result.shouldContain("/// :type typing.Optional\\[int\\]:")
     }
 }
diff --git a/rust-runtime/aws-smithy-http-server-python/src/types.rs b/rust-runtime/aws-smithy-http-server-python/src/types.rs
@@ -172,7 +172,7 @@ impl DateTime {
 
     /// Read 1 date of `format` from `s`, expecting either `delim` or EOF.
     ///
-    /// TODO: How do we represent `char` in Python?
+    /// TODO(PythonTyping): How do we represent `char` in Python?
     ///
     /// :param format Format:
     /// :param delim str: