Incorporate feedback

smithy-lang · Nov 15, 2022 · c29accf · c29accf
1 parent 9207c49
commit c29accf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/aws/rust-runtime/aws-config/src/imds/client.rs b/aws/rust-runtime/aws-config/src/imds/client.rs
@@ -218,7 +218,7 @@ impl Client {
                     InnerImdsError::InvalidUtf8 => {
                         ImdsError::Unexpected("IMDS returned invalid UTF-8".into())
                     }
-                    _ => ImdsError::ErrorResponse {
+                    InnerImdsError::BadStatus => ImdsError::ErrorResponse {
                         response: context.into_raw().into_parts().0,
                     },
                 },

diff --git a/rust-runtime/aws-smithy-http/src/event_stream/receiver.rs b/rust-runtime/aws-smithy-http/src/event_stream/receiver.rs
@@ -162,10 +162,7 @@ impl<T, E> Receiver<T, E> {
                     Err(SdkError::service_error(err, RawMessage::Decoded(message)))
                 }
             },
-            Err(err) => Err(SdkError::response_error(
-                Box::new(err),
-                RawMessage::Decoded(message),
-            )),
+            Err(err) => Err(SdkError::response_error(err, RawMessage::Decoded(message))),
         }
     }
 
@@ -195,7 +192,7 @@ impl<T, E> Receiver<T, E> {
                     .decode_frame(self.buffer.buffered())
                     .map_err(|err| {
                         SdkError::response_error(
-                            Box::new(err),
+                            err,
                             // the buffer has been consumed
                             RawMessage::Invalid(None),
                         )

diff --git a/rust-runtime/aws-smithy-http/src/event_stream/sender.rs b/rust-runtime/aws-smithy-http/src/event_stream/sender.rs
@@ -55,7 +55,7 @@ pub struct MessageStreamError {
 }
 
 #[derive(Debug)]
-pub enum MessageStreamErrorKind {
+enum MessageStreamErrorKind {
     Unhandled(Box<dyn std::error::Error + Send + Sync + 'static>),
 }