Only generate __init__ for classes that have constructor signatures

smithy-lang · Jan 3, 2023 · fb5bcd7 · fb5bcd7
1 parent 5e56f45
commit fb5bcd7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.../amazon/smithy/rust/codegen/server/python/smithy/generators/PythonApplicationGenerator.kt b/.../amazon/smithy/rust/codegen/server/python/smithy/generators/PythonApplicationGenerator.kt
@@ -105,6 +105,7 @@ class PythonApplicationGenerator(
             """
             ##[#{pyo3}::pyclass]
             ##[derive(Debug)]
+            /// :rtype None:
             pub struct App {
                 handlers: #{HashMap}<String, #{SmithyPython}::PyHandler>,
                 middlewares: Vec<#{SmithyPython}::PyMiddlewareHandler>,

diff --git a/rust-runtime/aws-smithy-http-server-python/examples/stubgen.py b/rust-runtime/aws-smithy-http-server-python/examples/stubgen.py
@@ -222,8 +222,16 @@ def make_class(
             print(f"Unknown member type={member}")
 
     if inspect.getdoc(klass) is not None:
-        is_empty = False
-        definition += make_function(writer, "__init__", klass, indent_level + 4) + "\n"
+        constructor_sig = DocstringParser.parse(klass)
+        if constructor_sig is not None and (
+            # Make sure to only generate `__init__` if the class has a constructor defined
+            len(constructor_sig.rtypes) > 0
+            or len(constructor_sig.params) > 0
+        ):
+            is_empty = False
+            definition += (
+                make_function(writer, "__init__", klass, indent_level + 4) + "\n"
+            )
 
     if is_empty:
         definition += indent(f"...\n", indent_level + 4)