Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SdkBody and bytestream into aws-smithy-types #3053

Closed
Tracked by #3019
ysaito1001 opened this issue Oct 10, 2023 · 0 comments
Closed
Tracked by #3019

Move SdkBody and bytestream into aws-smithy-types #3053

ysaito1001 opened this issue Oct 10, 2023 · 0 comments
Assignees

Comments

@ysaito1001
Copy link
Contributor

No description provided.

github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2023
## Motivation and Context
Takes care of the first part of
#3053 (the remaining part is
denoted as `TODO(runtimeCratesVersioningCleanup)` and until that and
#3033 are done the issue will
not be closed).

## Description
This PR moves from `aws-smithy-http` to `aws-smithy-types`:
- the `SdkBody` struct
- the `byte_stream` module

Within the origin crate, we leave "breadcrumbs" (i.e. reexports) for
existing customers of the items above so they are not broken by the
move.

We have just moved `SdkBody` to `aws-smithy-types` without renaming it
to see how it looks there. However, as
[TODO(naming)](https://github.com/awslabs/smithy-rs/pull/3026/files#diff-090c503b779024fdadb8ac97465c80438635df82e62c42b0d85b588a303d9a95R28)
says, we can choose to rename it to just `Body`. Curious to hear what
the reviewers think.

## Testing
Relied on the tests in CI.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Russell Cohen <rcoh@amazon.com>
@rcoh rcoh closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants