Move aws_smithy_http::BuildError into aws-smithy-types
#3054
Assignees
Comments
8 tasks
1 task
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 12, 2023
…-types` (#3032) ## Motivation and Context Takes care of the first part of #3054 (the remaining part is denoted as `TODO(runtimeCratesVersioningCleanup)` and until that's done the issue will not be closed). ## Description This PR moves from `aws-smithy-http::operation::error::{BuildError, SerializationError}` to `aws-smithy-types::error::operation::{BuildError, SerializationError}`. Within the origin crate, we leave "breadcrumbs" (i.e. reexports) for existing customers of the items above so they are not broken by the move. The breadcrumps will be removed by the part two of the issue. As part of the move, `aws_smithy_http::endpoint::EndpointPrefix::new` now returns its `crate::endpoint::error::InvalidEndpointError` instead of `crate::operation::error::BuildError` for two reasons: - `BuildError` is now in a stable crate and for an `InvalidUri` variant to be created, it needed to take a `http::uri::InvalidUri` from a unstable crate, which we cannot expose in public API. - The new error is more closely related to the endpoint business. ## Testing Relied on the tests in CI. ## Checklist - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: John DiSanti <jdisanti@amazon.com>
1 task
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 19, 2023
…3070) ## Motivation and Context Completes #3054 (a follow-up on #3032) ## Description #3032 moved `BuildError` from `aws_smithy_http::operation::error` to `aws_smithy_types::error::operation`. That PR also left "breadcrumbs", so that customers could still consume `BuldError` from `aws_smithy_http` after the move. This PR turns breadcrumbs into deprecation messages (via `#[deprecated(...)]`) and updates existing places that used to use moved types from `aws_smithy_http` to `aws_smithy_types`. ## Testing Relied on tests in CI. ## Checklist - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Russell Cohen <rcoh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: