Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: MSRV from 1.56.1 to 1.58.1 #1325

Merged
merged 5 commits into from
Apr 15, 2022
Merged

update: MSRV from 1.56.1 to 1.58.1 #1325

merged 5 commits into from
Apr 15, 2022

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Apr 15, 2022

Motivation and Context

#1318

Description

This PR bumps the SDK's MSRV from 1.56.1 to 1.58.1 per our MSRV "2 versions behind" policy. It also fixes many issues highlighted by the latest clippy lints.

Testing

ran existing tests

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -3.53% 71977.68 74608.21
Total requests -3.52% 6484234 6720710
Total errors NaN% 0 0
Total successes -3.52% 6484234 6720710
Average latency ms 10.62% 1.25 1.13
Minimum latency ms 100.00% 0.02 0.01
Maximum latency ms -20.01% 23.54 29.43
Stdev latency ms 5.50% 2.11 2
Transfer Mb -3.52% 674.04 698.62
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -0.17% 77906.42 78035.72
Total requests -0.08% 7019223 7024861
Total errors NaN% 0 0
Total successes -0.08% 7019223 7024861
Average latency ms -4.10% 1.17 1.22
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -1.67% 23.55 23.95
Stdev latency ms -5.71% 1.98 2.1
Transfer Mb -0.08% 729.65 730.24
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@Velfi Velfi marked this pull request as ready for review April 15, 2022 17:54
@Velfi Velfi requested a review from a team as a code owner April 15, 2022 17:54
CHANGELOG.next.toml Outdated Show resolved Hide resolved
@@ -131,6 +131,7 @@ impl ProvideCredentials for EcsCredentialsProvider {

/// Inner Provider that can record failed configuration state
#[derive(Debug)]
#[allow(clippy::large_enum_variant)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How big is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

432 bytes, the next largest is 56 bytes. Clippy recommends boxing it.

CHANGELOG.next.toml Outdated Show resolved Hide resolved
CHANGELOG.next.toml Outdated Show resolved Hide resolved
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 6.53% 68549.29 64348.73
Total requests 6.51% 6172636 5795365
Total errors NaN% 0 0
Total successes 6.51% 6172636 5795365
Average latency ms -3.51% 0.55 0.57
Minimum latency ms -50.00% 0.01 0.02
Maximum latency ms -13.42% 18.58 21.46
Stdev latency ms 4.29% 0.73 0.7
Transfer Mb 6.51% 641.65 602.43
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@Velfi Velfi merged commit 52b808e into main Apr 15, 2022
@Velfi Velfi deleted the update/msrv-to-1_58_1 branch April 15, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants