Add server extra tests #1425
Closed
Add server extra tests #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
|
Depends on #1424 |
david-perez
requested changes
Jun 1, 2022
| @@ -660,7 +660,6 @@ class ServerProtocolTestGenerator( | |||
| FailingTest(RestJson, "RestJsonHttpWithEmptyStructurePayload", TestType.Request), | |||
| FailingTest(RestJson, "RestJsonHttpResponseCodeDefaultsToModeledCode", TestType.Response), | |||
|
|
|||
| FailingTest(RestJson, "RestJsonWithPayloadExpectsImpliedAccept", TestType.MalformedRequest), | |||
There was a problem hiding this comment.
I think this is a leftover from your other PR. It's causing CI to fail here, since we're not fixing this test in this PR.
| @@ -0,0 +1,126 @@ | |||
| $version: "1.0" | |||
There was a problem hiding this comment.
Don't copy the contents of this file. Symlink it so that both client and server use the same model. See simple.smithy for example.
➜ file codegen-test/model/simple.smithy
codegen-test/model/simple.smithy: symbolic link to ../../codegen-server-test/model/simple.smithy
added 6 commits
June 7, 2022 10:29
Comply with content-types as described in the documentation [0] [0] https://awslabs.github.io/smithy/1.0/spec/aws/aws-restjson1-protocol.html#content-type Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Add rest-json-extras.smithy and protocol tests that are now failing in smithy-rs, but are not correct from smithy Closes: #1164 Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See: #1164
Description
Tests:
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.