Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Endpoint panic-safety and ergonomics #1984

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Improve Endpoint panic-safety and ergonomics #1984

merged 5 commits into from
Nov 17, 2022

Commits on Nov 16, 2022

  1. Improve Endpoint panic-safety and ergonomics 

    - `Endpoint::set_endpoint` no longer panics when called on an endpoint
  without a scheme
- `Endpoint::mutable` and `Endpoint::immutable` now both return a result
  so that constructing an endpoint without a scheme is an error
- `Endpoint::mutable` and `Endpoint::immutable` both now take a string
  instead of a `Uri` as a convenience
- `Endpoint::mutable_uri` and `Endpoint::immutable_uri` were added
  to construct an endpoint directly from a `Uri`
    @jdisanti
    jdisanti committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    50e4e1c View commit details
    Browse the repository at this point in the history

  2. Update the changelog

    @jdisanti
    jdisanti committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    7e04581 View commit details
    Browse the repository at this point in the history

  3. Incorporate feedback

    @jdisanti
    jdisanti committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    8725d88 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into jdisanti-set-endpoint… 

    …-dont-panic
    @jdisanti
    jdisanti committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    24bb04d View commit details
    Browse the repository at this point in the history

  5. Fix CI failures

    @jdisanti
    jdisanti committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    a62726d View commit details
    Browse the repository at this point in the history