refactor: extract retry quota into a tower service #2172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysaito1001
reviewed
Jan 6, 2023
|
|
||
| #[test] | ||
| fn retry_handler_send_sync() { | ||
| fn must_be_send_sync<T: Send + Sync>() {} |
There was a problem hiding this comment.
This is cool. I know there is a crate out there called static-assertions, but what we have here will do.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
reviewed
Jan 6, 2023
Comment on lines
119
to
121
| if self.state.available() == 0 { | ||
| // If no quota is available, report pending | ||
| Poll::Pending |
There was a problem hiding this comment.
this won't quite work—we need to schedule a wakeup when state goes back above 0. As written, if state goes to 0, that task will never get woken up
|
I'm going to focus on implementing the |
add: token bucket remove: token bucket from retry
Velfi
force-pushed
the
refactor/extract-retry-quota-into-tower-service
branch
from
0556f33
to
c6244ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1785
Description
This PR extracts the retry quota state from the
RetryHandlerand places it in its owntower::Layer. This is a first step in the process to introduce adaptive retry behavior which will use its own specialized retry quota layer.Testing
Ran existing tests
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.