Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job trigger. Clarify that short SHAs won't work. #2278

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix job trigger. Clarify that short SHAs won't work. #2278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ on:
workflow_dispatch:
inputs:
commit_sha:
description: The SHA of the git commit that you want to release (e.g. b2318b0)
description: |
The SHA of the git commit that you want to release.
You must use the non-abbreviated SHA (e.g. b2318b0 won't work!).
required: true
type: string
semantic_version:
Expand Down Expand Up @@ -69,6 +71,13 @@ jobs:
name: Get or create a release branch
needs:
- release-ci
- acquire-base-image
# We need `always` here otherwise this job won't run if the previous job has been skipped
# See https://samanpavel.medium.com/github-actions-conditional-job-execution-e6aa363d2867
if: |
always() &&
needs.acquire-base-image.result == 'success' &&
(needs.release-ci.result == 'success' || needs.release-ci.result == 'skipped')
runs-on: ubuntu-latest
outputs:
release_branch: ${{ steps.branch-push.outputs.release_branch }}
Expand Down Expand Up @@ -121,7 +130,7 @@ jobs:
echo "Pushing upgraded gradle.properties commit..."
git push origin
fi
echo "commit_sha=$(git rev-parse --short HEAD)" > $GITHUB_OUTPUT
echo "commit_sha=$(git rev-parse HEAD)" > $GITHUB_OUTPUT

release:
name: Release
Expand Down