Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the service builder RFCs #2374

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Update the service builder RFCs #2374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6efff8
Complete service_builder.md
Feb 14, 2023
487a2ad
Complete refine_builder.md
Feb 14, 2023
efdf29c
Merge branch 'main' into harryb/update-svc-builder-rfc
hlbarber Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion design/src/rfcs/rfc0020_service_builder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,4 +862,6 @@ A toy implementation of the combined proposal is presented in [this PR](https://
- <https://github.com/awslabs/smithy-rs/pull/1679>
- [x] Add code generation which outputs new service builder.
- <https://github.com/awslabs/smithy-rs/pull/1693>
- [ ] Deprecate `OperationRegistryBuilder`, `OperationRegistry` and `Router`.
- [x] Deprecate `OperationRegistryBuilder`, `OperationRegistry` and `Router`.
- <https://github.com/awslabs/smithy-rs/pull/1886>
- <https://github.com/awslabs/smithy-rs/pull/2161>
9 changes: 6 additions & 3 deletions design/src/rfcs/rfc0023_refine_builder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,9 +781,12 @@ The API proposed in this RFC has been manually implemented for the Pokemon servi

## Changes checklist

- [ ] Update `codegen-server` to generate the proposed service builder API
- [ ] Implement `Pluggable` for `PluginStack`
- [ ] Evaluate the introduction of a `PluginBuilder` as the primary API to compose multiple plugins (instead of `PluginStack::new(IdentityPlugin, IdentityPlugin).apply(...)`)
- [x] Update `codegen-server` to generate the proposed service builder API
- <https://github.com/awslabs/smithy-rs/pull/1954>
- [x] Implement `Pluggable` for `PluginStack`
- <https://github.com/awslabs/smithy-rs/pull/1954>
- [x] Evaluate the introduction of a `PluginBuilder` as the primary API to compose multiple plugins (instead of `PluginStack::new(IdentityPlugin, IdentityPlugin).apply(...)`)
- <https://github.com/awslabs/smithy-rs/pull/1971>

[RFC 20]: rfc0020_service_builder.md
[Pokemon service]: https://github.com/awslabs/smithy-rs/blob/c7ddb164b28b920313432789cfe05d8112a035cc/codegen-core/common-test-models/pokemon.smithy
Expand Down