-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uncessary type parameter and constraints from Upgrade
service
#2436
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why was this type variable there in the first place?
- Will we be removing any of the other phantom type variables in
Upgrade
later?
You might want to update these docs (they seem to have an outdated version of Upgrade
with only 3 tyvars).
Just a mistake - I'm guessing I was mucking around with types and it was required in a previous iteration.
It's a possibility, this PR was motivated by a specific excess constraint. A more general investigation can be performed and might reveal some extra redundancy.
This was intentional to simplify the documentation. There do seems to be some references to |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
The type parameter
B
was not only redundant but also removed a degree of freedom from the API.Description
B
fromUpgrade
and related code.