Refactor aws smithy types #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjant
reviewed
Apr 26, 2023
CHANGELOG.next.toml
Outdated
Comment on lines
175
to
185
| [[aws-sdk-rust]] | ||
| message = "Refactor aws-smithy-types crate. Blob, Datetime, Number and Document structs now goes to it's own files. No breaking changes." | ||
| references = ["smithy-rs#2616"] | ||
| meta = { "breaking" = false, "tada" = false, "bug" = true } | ||
| author = "thomas-k-cameron" | ||
|
|
||
| [[smithy-rs]] | ||
| message = "Refactor aws-smithy-types crate. Blob, Datetime, Number and Document structs now goes to it's own files. No breaking changes." | ||
| references = ["smithy-rs#2616"] | ||
| meta = { "breaking" = false, "tada" = false, "bug" = true } | ||
| author = "thomas-k-cameron" |
There was a problem hiding this comment.
These changes don't change the public API in any way, right? If so, I don't think we need these changelog entries. I'm also not sure about why the "bug" = true either 🤔
There was a problem hiding this comment.
Yes, it doesn't change the API.
I thought that I have to mention refactoring too.
"bug" = true
This one is simple mistake on my side.
Thank you for letting me know. Let me fix it up.
hlbarber
added
breaking-change
Velfi
approved these changes
Apr 26, 2023
david-perez
pushed a commit
that referenced
this pull request
May 18, 2023
## Motivation and Context This PR refactors `aws-smithy-types` crate. `Blob`, `Datetime`, `Number` and `Document` structs now goes to it's own files. No changes on feature is introduced. This is a child-PR of #2616 . However, it is completely independent. PR that introduces same changes were previously merged to `unstable-serde` branch, however, it has not been merged to main branch. ## Testing NA ## Checklist This PR does not introduce API changes. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
## Motivation and Context This PR refactors `aws-smithy-types` crate. `Blob`, `Datetime`, `Number` and `Document` structs now goes to it's own files. No changes on feature is introduced. This is a child-PR of #2616 . However, it is completely independent. PR that introduces same changes were previously merged to `unstable-serde` branch, however, it has not been merged to main branch. ## Testing NA ## Checklist This PR does not introduce API changes. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
## Motivation and Context This PR refactors `aws-smithy-types` crate. `Blob`, `Datetime`, `Number` and `Document` structs now goes to it's own files. No changes on feature is introduced. This is a child-PR of #2616 . However, it is completely independent. PR that introduces same changes were previously merged to `unstable-serde` branch, however, it has not been merged to main branch. ## Testing NA ## Checklist This PR does not introduce API changes. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR refactors
aws-smithy-typescrate.Blob,Datetime,NumberandDocumentstructs now goes to it's own files.No changes on feature is introduced.
This is a child-PR of #2616 .
However, it is completely independent.
PR that introduces same changes were previously merged to
unstable-serdebranch, however, it has not been merged to main branch.Testing
NA
Checklist
This PR does not introduce API changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.