Render only shape name in server error responses #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially reverts the behavior introduced in #1982. The rationale for that change: > [...] since some existing clients rely on it to deserialize the error shape > and fail if only the shape name is present no longer holds. Since serializing only the shape name is a SHOULD in the spec, it's best that we honor it.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
approved these changes
Jul 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…-shape-name-in-server-error-responses
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
deleted the
davidpz/render-only-shape-name-in-server-error-responses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially reverts the behavior introduced in #1982.
The rationale for that change:
no longer holds. Since serializing only the shape name is a SHOULD in
the spec, it's best that we honor it.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.