Add Initial Support for Hyper 1.0 #3461
Conversation
rcoh
force-pushed
the
hyper-10-experimental
branch
from
f4a041c
to
04a6656
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| hyper_rustls::HttpsConnectorBuilder::new() | ||
| .with_tls_config( | ||
| rustls::ClientConfig::builder_with_provider(Arc::new(restrict_ciphers(crypto_provider))) | ||
| //.with_safe_default_kx_groups() |
There was a problem hiding this comment.
ah they removed that — it is only safe now.
| None | ||
| } | ||
|
|
||
| // TODO(https://github.com/awslabs/aws-sdk-rust/issues/1090): CacheKey must also include ptr equality to RuntimeComponents |
There was a problem hiding this comment.
I think pointer equality will end up ballooning the cached connectors into a memory leak if someone uses a config override on a operation. We'll have to come up with something else.
There was a problem hiding this comment.
ah yeah—that comment is badly worded. It should be the specific components of RC that are used.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
hyper-10-experimental
branch
from
e5aa298
to
a8874a7
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| @@ -28,7 +28,6 @@ hex = "0.4" | |||
| hmac = "0.12" | |||
| http0 = { version = "0.2", optional = true, package = "http" } | |||
| http = { version = "1", optional = true } | |||
| num-bigint = { version = "0.4.2", optional = true } | |||
Motivation and Context
Description
This adds a minimal Hyper client, focusing on not exposing any unstable APIs. For this reason, the
Client::Buildercustomization API is not exposed anymore. We do this because at some point in the future, we will likely move away from the hyper-util based Client.The code for this was lifted directly from the Hyper 0.14 implementation but updated for new traits.
However, this does come with some new valuable pieces:
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.