-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Smithy to 1.45 #3470
Upgrade Smithy to 1.45 #3470
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
There's something weird going on with the
I think I fixed the test incorrectly, but now I'm puzzled why the fixed test in smithy-rs didn't break. I guess it must not be running for some reason. |
It appears the codegen-server-test subproject doesn't regenerate any code when changing the rest-json-extras model. That's unfortunate. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smithy-lang/smithy#2167 seems to have been merged so it may not be too long before tests with TODO can be removed. The changes LGTM.
A new generated diff is ready to view.
A new doc preview is ready to view. |
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.