CI: Only allow daily credentials verification to run on smithy-lang/ repo #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repo Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
|
Thanks for updating the workflow! Separately verified that the daily credentials workflow passed with the changes from this PR. |
ysaito1001
approved these changes
Apr 22, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 24, 2024
…n ci workflow is triggered from main smithy-rs repository (#3663) Similar to #3597. Only run these two workflows when they are triggered from the `smithy-lang/smithy-rs` repository, not from any fork. ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> The scheduled dry run fails daily in forks, failing each time, triggering alerts to the owner of the fork repository. The github pages publishing workflow does not run regularly in forks, but does run when a fork is synced. It would be undesirable for an arbitrary fork to publish. ## Description <!--- Describe your changes in detail --> On each of the two github workflows, add an `if` condition testing the repository owner and name. Only run if it matches the official repository, and is not a fork. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> n/a ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates n/a in both cases ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The CI job that checks CI credentials fails when run on forks, resulting in daily job failure alerts in forks.
Example failure: https://github.com/iamjpotts/aws-smithy-rs/actions/runs/8768654532
See #3519.
Description
For the
Daily Credentials Verificationworkflow, add a condition on each of its jobs so that they will only run for thesmithy-lang/smithy-rsrepo and not any forks.Testing
No code changes.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesCI only; no change log entry required.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.