behavior version 2024-03-28 #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
May 1, 2024
| assert!(config.credentials_provider().is_none()); | ||
| } | ||
|
|
||
| #[cfg(feature = "rustls")] |
There was a problem hiding this comment.
Does this cargo feature need to be set (which I assume it does since we also set it at line 1080 consistently)?
There was a problem hiding this comment.
Yes it fails without it and error indicates to enable it.
|
|
||
| #[derive(Copy, Clone, Debug, Ord, PartialOrd, Eq, PartialEq)] | ||
| enum Inner { | ||
| // IMPORTANT: Order matters here for the `Ord` derive. Newer versions go to the bottom. |
Co-authored-by: ysaito1001 <awsaito@amazon.com>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ogghead
pushed a commit
to ogghead/smithy-rs
that referenced
this pull request
May 5, 2024
This PR is the combination of two previously reviewed PRs that both enable new behaviors behind a new Behavior Major Version (BMV): * smithy-lang#3527 * smithy-lang#3578 * Enables stalled stream protection by default on latest behavior version. * Enables creation of a default identity cache. All testing done on prior PRs. See for details. <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: John DiSanti <jdisanti@amazon.com> Co-authored-by: ysaito1001 <awsaito@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR is the combination of two previously reviewed PRs that both enable new behaviors behind a new Behavior Major Version (BMV):
Description
Testing
All testing done on prior PRs. See for details.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.