Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expected content-type to ignore parameters #3724

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

djedward
Copy link
Contributor

Fixes: #3471

Motivation and Context

An issue was raised about a mobile client that appends "; charset=utf-8" to the Content-Type when using restJson1. The latest RFC for "application/json" does not register a charset parameter, but indicates it is reasonable to accept it.

Description

This change loosens the validation of the expected content type to allow all parameters.

Testing

  • Tests for each protocol were added to smithy
  • ran the runtime and codegen tests
  • Added test for rest-xml, as smithy-rs does not currently run the smithy tests.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@djedward djedward requested review from a team as code owners June 27, 2024 20:11
@ysaito1001
Copy link
Contributor

Ask maintainer to run the PR bot and canary workflows -> passed manual canary run against this PR.

@david-perez david-perez added this pull request to the merge queue Jun 28, 2024
Merged via the queue into smithy-lang:main with commit 4beac5f Jun 28, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@restJson1 and charset=utf8 in the header
4 participants