Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete nonprintable characters from aws-smithy-checksums test #3778

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Aug 1, 2024

Motivation and Context

The nonprintable characters in this source file make tools misidentify it as a binary file, rather than source code.

Description

Before:

$ file rust-runtime/aws-smithy-checksums/src/http.rs
rust-runtime/aws-smithy-checksums/src/http.rs: data

After:

$ file rust-runtime/aws-smithy-checksums/src/http.rs
rust-runtime/aws-smithy-checksums/src/http.rs: ASCII text

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dtolnay dtolnay requested a review from a team as a code owner August 1, 2024 18:20
@dtolnay dtolnay mentioned this pull request Aug 1, 2024
4 tasks
@dtolnay
Copy link
Contributor Author

dtolnay commented Aug 1, 2024

# Auditing runtime crate version numbers...
2024-08-01T19:23:27.698077Z  INFO runtime_versioner::command::audit: 'aws-config' changed and was version bumped from 1.5.4 to 1.5.5
2024-08-01T19:23:27.730127Z  INFO runtime_versioner::command::audit: 'aws-smithy-cbor' is a new crate (or wasn't independently versioned before) and will publish at 0.60.7
2024-08-01T19:23:27.755161Z  INFO runtime_versioner::command::audit: 'aws-smithy-http-server' changed and was version bumped from 0.63.1 to 0.63.2
2024-08-01T19:23:27.769870Z  INFO runtime_versioner::command::audit: 'aws-smithy-protocol-test' changed and was version bumped from 0.60.8 to 0.62.0
aws-smithy-checksums changed since release-2024-07-16 and requires a version bump
Error: there are audit failures in the runtime crates

@dtolnay
Copy link
Contributor Author

dtolnay commented Aug 1, 2024

PR bot and canary cannot be invoked from a forked repository. Ask a maintainer to manually invoke them using your PR.
Error: Process completed with exit code 1.

@ysaito1001
Copy link
Contributor

ysaito1001 commented Aug 2, 2024

PR bot and canary cannot be invoked from a forked repository. Ask a maintainer to manually invoke them using your PR.
Error: Process completed with exit code 1.

Passed.

This step is always marked as failure in PRs created from forked repos (we don't have a good way to communicate that in GitHub jobs result icons), but it is not a required step for PRs to be merged.

@dtolnay
Copy link
Contributor Author

dtolnay commented Aug 7, 2024

Rebased to resolve conflict with #3781 in aws/rust-runtime/Cargo.lock.

@ysaito1001 ysaito1001 added this pull request to the merge queue Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Merged via the queue into smithy-lang:main with commit 191103c Aug 7, 2024
41 of 42 checks passed
@dtolnay dtolnay deleted the nul branch August 7, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants