Fix constraint-related errors in Rpcv2CBOR server implementation #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
Can we add a changelog entry with |
drganjoo
force-pushed
the
fahadzub/cbor-constraint
branch
from
39d57f3
to
5bb92b1
Compare
…o fahadzub/cbor-constraint
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
fahadzub/cbor-constraint
branch
from
829cc8d
to
763d598
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
…e for event stream
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
fahadzub/cbor-constraint
branch
from
ea69024
to
050d9c5
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
approved these changes
Sep 17, 2024
...-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/RpcV2Cbor.kt
Outdated
Show resolved
Hide resolved
...e/src/main/kotlin/software/amazon/smithy/rust/codegen/core/testutil/EventStreamTestModels.kt
Outdated
Show resolved
Hide resolved
...n/smithy/rust/codegen/server/smithy/transformers/ServerProtocolBasedTransformationFactory.kt
Outdated
Show resolved
Hide resolved
...n/smithy/rust/codegen/server/smithy/transformers/ServerProtocolBasedTransformationFactory.kt
Show resolved
Hide resolved
| */ | ||
| fun loadSmithyConstraintsModel(): Pair<Model, ShapeId> { | ||
| val filePath = "../codegen-core/common-test-models/constraints.smithy" | ||
| val serviceShapeId = ShapeId.from("com.amazonaws.constraints#ConstraintsService") |
There was a problem hiding this comment.
nit: you could expect it from the parsed model below instead of hardcoding it.
There was a problem hiding this comment.
Have changed it to return the first service shape in the constraints file.
Co-authored-by: david-perez <d@vidp.dev>
Co-authored-by: david-perez <d@vidp.dev>
…en/core/smithy/protocols/RpcV2Cbor.kt Co-authored-by: david-perez <d@vidp.dev>
…en/core/testutil/EventStreamTestModels.kt Co-authored-by: david-perez <d@vidp.dev>
…tory class will be removed later on
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with code generation related to constraints for the Rpcv2CBOR protocol.
Additionally, it introduces protocol-based model transformation on the server side. This transformation ensures that elements in the model not supported by Rpcv2CBOR, such as httpBinding related traits, are removed before code generation.