Pin minicbor to 0.24.2
#3818
Merged
Pin minicbor to 0.24.2
#3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonxjames
approved these changes
Sep 3, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
## Description This PR updates lockfiles by running: ``` ./gradlew aws:sdk:generateAllLockfiles -Paws-sdk-rust-path=/Users/awsaito/src/aws-sdk-rust ``` However, due to [the minicbor issue](#3818), we still pin it to 0.24.2 by running the following on `rust-runtime/Cargo.lock` and `aws/sdk/Cargo.lock`: ``` RUSTFLAGS="--cfg aws_sdk_unstable" cargo update -p minicbor --precise 0.24.2 ``` The rest of the changes handle miscellaneous scenarios: - **Updated nightly version**: Upgraded to `nightly-2024-03-15` to address a [compatibility issue](serde-rs/serde#2770) introduced by the updated serde library. - **Cleaned up use statements**: Removed redundant use statements, which were flagged as warnings by the new nightly version. ## Testing Tests in CI ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
aws-sdk-rust-ci
pushed a commit
to awslabs/aws-sdk-rust
that referenced
this pull request
Sep 10, 2024
## Description This PR updates lockfiles by running: ``` ./gradlew aws:sdk:generateAllLockfiles -Paws-sdk-rust-path=/Users/awsaito/src/aws-sdk-rust ``` However, due to [the minicbor issue](smithy-lang/smithy-rs#3818), we still pin it to 0.24.2 by running the following on `rust-runtime/Cargo.lock` and `aws/sdk/Cargo.lock`: ``` RUSTFLAGS="--cfg aws_sdk_unstable" cargo update -p minicbor --precise 0.24.2 ``` The rest of the changes handle miscellaneous scenarios: - **Updated nightly version**: Upgraded to `nightly-2024-03-15` to address a [compatibility issue](serde-rs/serde#2770) introduced by the updated serde library. - **Cleaned up use statements**: Removed redundant use statements, which were flagged as warnings by the new nightly version. ## Testing Tests in CI ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge to the release branch
Motivation and Context
Fixes a failure observed in our release pipeline
Description
A lockfile located at
aws/sdk/Cargo.lockdid not include theminicborcrate that was introduced as part of RPC V2 CBOR. This has caused a build failure in our release pipeline due to a new version ofminicbor0.24.3 uploaded to crates.io.To address this issue, this PR pins
minicborto 0.24.2 inaws/sdk/Cargo.lock(rust-runtime/Cargo.lockalready pins it to 0.24.2)The change in
aws/sdk/Cargo.lockwas obtained bygit pullin/Users/awsaito/src/aws-sdk-rust./gradlew aws:sdk:generateAllLockfiles -Paws-sdk-rust-path=/Users/awsaito/src/aws-sdk-rustminicborIn addition, since the release of aws-sdk-rust the other day, smoke tests have started getting rendered and compiled in cargo-semver-checks. This has caused cargo-semver-checks to exceed the previous timeout of 20 minutes. To address it, we have increased the timeout to 30 minutes.
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.