Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stalled stream protection from transcribestreaming #3831

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

landonxjames
Copy link
Contributor

Motivation and Context

awslabs/aws-sdk-rust#1181

Checklist

  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@landonxjames landonxjames requested review from a team as code owners September 15, 2024 02:41
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link
Contributor

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now and follows existing conventions.

I think we really want to change how we structure customizations though. This removal of stalled stream protection is scattered around instead of being defined in one place. This isn't the only offender either. We should probably define it as a customization describing what it does and apply it to as many services/operations there.

e.g.

/// Disable stalled stream protection for specific operations that are not compatible
/// (e.g. where waiting for the service to respond is expected). 
class DisableStalledStreamProtection : ClientCodegenDecorator {
      private val appliesTo = setOf( ... )
}

In Kotlin (and other smithy code generators) this is pretty common (examples: common customization, service specific)

@landonxjames
Copy link
Contributor Author

I think we really want to change how we structure customizations though. This removal of stalled stream protection is scattered around instead of being defined in one place. This isn't the only offender either. We should probably define it as a customization describing what it does and apply it to as many services/operations there.

Agree I thought of that while I was doing this, but it was the weekend and I wasn't going to spend too much time on it. I created #3835 to track this and I'll hopefully get around to it when oncall/flexible checksums/observability are all mopped up. Adding it to our tracking board as well.

@landonxjames landonxjames added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit d288ef9 Sep 16, 2024
44 checks passed
@landonxjames landonxjames deleted the landonxjames/ssptranscribe branch September 16, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants