Address post-merge feedback on smithy-rs#3827 #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses #3827 (comment)
This commit addresses #3827 (comment) #3827 (comment)
This commit addresses #3827 (comment)
This commit addresses #3827 (comment)
This commit addresses #3827 (comment)
This commit addresses #3827 (comment)
ysaito1001
commented
Sep 16, 2024
Comment on lines
+40
to
+42
| This limitation is acceptable for our operational purposes. Our release script always executes | ||
| `./gradlew aws:sdk:syncAwsSdkLockfile`, which ensures that any dependencies added in `CargoDependency.kt` are properly | ||
| reflected in the SDK lockfile. |
There was a problem hiding this comment.
This is something I'm planning to implement in a subsequent PR.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Primarily for @drganjoo providing feedback on smithy-rs#3827 (thanks), but anyone is welcome to review the changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.