Update Smoketest codegen to be endpoint param aware #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysaito1001
approved these changes
Sep 17, 2024
ysaito1001
reviewed
Sep 17, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Co-authored-by: ysaito1001 <awsaito@amazon.com>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> Add tests the were skipped in #3836 in favor of merging and unblocking customer. ## Description <!--- Describe your changes in detail --> Testing our smoketest generator with the `UseDualStack` and `UseFips` endpoint built-ins. Previously the smoketest generator assumed that these were always available, but they are only available if those built-ins are included in the endpoints rule set of the model. We now test the smoke test with both of these built-ins, with each by itself, and with neither. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Checklist Just a test change, no changelog ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: ysaito1001 <awsaito@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Smoketests for service were failing because the smoke test assumed that
use_dual_stackwould be present. But the service's endpoint rules did not use that bulit-in so it was not.Description
Check if the service actually uses the fips or dual stack built-ins before adding them to the test.
Testing
Did not add tests for this because the current
SmokeTestsDecoratorTestisn't actually working and fixing it is going to be a bit of work. Want to get this in to unblock customer ASAP and will go back and update the tests once they are unblocked.Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.